From 5f196253b33c4aa3d6cfb1bb15fec1ecdf1738fd Mon Sep 17 00:00:00 2001
From: hoshiizumiya <63837495+hoshiizumiya@users.noreply.github.com>
Date: Sun, 23 Nov 2025 21:24:10 +0800
Subject: [PATCH] Enhance failure count handling in RepositoryAffinity

Add lower bounds protection for failure counts to prevent negative values and integer underflow.
---
 .../Service/Git/RepositoryAffinity.cs         | 21 +++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/src/Snap.Hutao/Snap.Hutao/Service/Git/RepositoryAffinity.cs b/src/Snap.Hutao/Snap.Hutao/Service/Git/RepositoryAffinity.cs
index 69f5cda..4b16f92 100644
--- a/src/Snap.Hutao/Snap.Hutao/Service/Git/RepositoryAffinity.cs
+++ b/src/Snap.Hutao/Snap.Hutao/Service/Git/RepositoryAffinity.cs
@@ -24,7 +24,10 @@ internal static class RepositoryAffinity
             {
                 GitRepository repository = repositories[i];
                 string key = GetSettingKey(repository.Name, repository.HttpsUrl.OriginalString);
-                counts[i] = LocalSetting.Get(key, 0);
+
+                // 对读取值做下限保护，确保排序使用的是非负失败计数
+                int raw = LocalSetting.Get(key, 0);
+                counts[i] = Math.Max(0, raw);
             }
 
             Array.Sort(counts, ImmutableCollectionsMarshal.AsArray(repositories));
@@ -43,7 +46,12 @@ internal static class RepositoryAffinity
         {
             string key = GetSettingKey(name, url);
             int currentCount = LocalSetting.Get(key, 0);
-            LocalSetting.Set(key, unchecked(currentCount + 1));
+
+            // 防止整数上溢：当已到达 int.MaxValue 时不再自增
+            if (currentCount < int.MaxValue)
+            {
+                LocalSetting.Set(key, currentCount + 1);
+            }
         }
     }
 
@@ -58,7 +66,12 @@ internal static class RepositoryAffinity
         {
             string key = GetSettingKey(name, url);
             int currentCount = LocalSetting.Get(key, 0);
-            LocalSetting.Set(key, unchecked(currentCount - 1));
+
+            // 失败次数不允许小于 0，避免出现负数或整型下溢
+            if (currentCount > 0)
+            {
+                LocalSetting.Set(key, currentCount - 1);
+            }
         }
     }
 
@@ -67,4 +80,4 @@ internal static class RepositoryAffinity
         string urlHash = Hash.ToHexString(HashAlgorithmName.SHA256, url.ToUpperInvariant());
         return $"{RepositoryAffinityPrefix}{name}::{urlHash}";
     }
-}
\ No newline at end of file
+}